nala/Investidor-V2
1
0
Fork 0
Code Issues Pull Requests Actions 18 Packages Projects Releases Wiki Activity

fix: keep private idea preparation valid in complement lookup

Browse Source
This commit is contained in:
nala
2026-10-27 12:01:24 +02:00
parent 403c444a3e
commit 51d536b7ba
2 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Services/InvestmentComplements.php
+4
View File
@@ -46,6 +46,10 @@ final class InvestmentComplements
} else {
$reference = app(InvestorContext::class)->reference($origin);
abort_unless($reference['kind'] === 'opportunity', 422);
// The context resolver has already checked the actor's private scope.
// A private preparation is valid dossier input, not a public offer
// from which this public-complement catalogue can infer services.
if (($reference['visibility'] ?? 'public') === 'private') return [];
$principal = Opportunity::published()->findOrFail($reference['id']);
$text = $principal->summary;
$basis = 'Resumo cadastrado da oportunidade '.$principal->reference;
tests/Feature/ProactiveInvestmentTest.php
+22
View File
@@ -140,6 +140,28 @@ final class ProactiveInvestmentTest extends TestCase
$this->assertTrue(app(\App\Services\InvestmentCatalogue::class)->query(['perspective'=>$kind])->whereKey($id)->exists());
}
}
public function test_private_analysis_complements_keep_preparation_valid_without_inventing_public_offers(): void
{
$private=$this->create('Gurué');$public=$this->create();
$input=$this->publication($public,['summary'=>'SYNTHETIC QA: silos e armazenagem como componente documentada.']);
$plan=$this->postJson('/minhas-oportunidades/'.$public->id.'/divulgacao/previa',$input)->assertOk()->json();
$this->postJson('/minhas-oportunidades/'.$public->id.'/divulgacao/confirmar',['token'=>$plan['token'],'operation_key'=>(string)Str::uuid(),'confirm'=>true,'reason'=>'SYNTHETIC QA public component in transaction only'])->assertOk();
$result=$this->postJson('/complementos-investimento',['contexts'=>[['origin'=>'opportunity:'.$private->id],['origin'=>'opportunity:'.$public->id]]])->assertOk()->json();
$this->assertSame([],$result['issues']);$this->assertNotEmpty($result['items']);
foreach($result['items']as$item)$this->assertSame('opportunity:'.$public->id,$item['origin']['key']);
$this->assertStringNotContainsString('PRIVATE-QA-',json_encode($result));
$this->assertFalse(Opportunity::published()->whereKey($private->id)->exists());
$this->assertSame('draft',$private->fresh()->status);
}
public function test_private_analysis_complements_still_hide_unauthorised_sources(): void
{
$private=$this->create('Gurué');$this->login(User::factory()->create());
$this->postJson('/complementos-investimento',['origin'=>'opportunity:'.$private->id])->assertNotFound();
$result=$this->postJson('/complementos-investimento',['contexts'=>[['origin'=>'opportunity:'.$private->id]]])->assertOk()->json();
$this->assertSame([],$result['items']);$this->assertCount(1,$result['issues']);
$this->assertStringNotContainsString($private->title,json_encode($result));
$this->assertStringNotContainsString('PRIVATE-QA-',json_encode($result));
}
public function test_authenticated_multi_idea_preparation_keeps_each_origin_and_deliberate_edits_in_existing_dossier(): void
{
$first=$this->create();$second=$this->create('Gurué');$this->publish($first);$this->publish($second);$investor=User::factory()->create();$this->login($investor);