fix(offers): preserve description in authorised investment context

This commit is contained in:
2026-11-14 18:39:25 +02:00
parent ed2fd86f6b
commit 9a01426864
21 changed files with 1219 additions and 10 deletions
@@ -5,17 +5,21 @@ namespace Tests\Feature;
use App\Models\Opportunity;
use App\Models\User;
use App\Services\InvestorContext;
use App\Services\OfferPublicCatalogue;
use App\Services\OpportunityManagement;
use App\Services\PortalProfileAdministration;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Str;
use Tests\TestCase;
/** Acceptance audit only: no change to the product's contracts or access rules. */
/** Synthetic acceptance regression for the existing investment-context boundary. */
final class OfferInvestmentAcceptanceAuditTest extends TestCase
{
use RefreshDatabase;
private function prepare(): array
private function prepare(array $location = []): array
{
$this->withoutVite();
config(['portal.profile_access_enabled' => true]);
@@ -28,7 +32,7 @@ final class OfferInvestmentAcceptanceAuditTest extends TestCase
'title' => 'Synthetic acquisition acceptance', 'description' => 'Existing company description to reuse once in investment preparation.',
'private_offer' => ['price_mode' => 'amount', 'amount' => '120000.00', 'currency' => 'MZN',
'business' => ['revenue' => '60000.00', 'cash_flow' => '20000.00', 'currency' => 'MZN']],
'reason' => 'Synthetic final acceptance integration audit only.'];
'reason' => 'Synthetic final acceptance integration audit only.', ...$location];
$record = $this->actingAs($owner)->postJson('/minhas-oportunidades/ofertas/rascunhos', $payload)->assertCreated()->json('record');
return [$owner, $record, $payload];
@@ -42,6 +46,10 @@ final class OfferInvestmentAcceptanceAuditTest extends TestCase
$this->assertSame($payload['title'], $reference['fields']['project_title']);
$this->assertSame($payload['description'], $reference['fields']['project_summary'] ?? null,
'Write once/read always: the existing description must not disappear at the investment-context boundary.');
$this->assertSame('/minhas-oportunidades/ofertas/'.$record['id'], $reference['href']);
$this->assertArrayNotHasKey('private_offer', $reference);
$this->assertArrayNotHasKey('revenue', $reference['fields']);
$this->assertArrayNotHasKey('currency', $reference['fields']);
}
public function test_native_context_options_do_not_disclose_another_owners_private_offer(): void
@@ -55,4 +63,113 @@ final class OfferInvestmentAcceptanceAuditTest extends TestCase
$this->assertNotContains('opportunity:'.$record['id'], array_column(app(InvestorContext::class)->options(), 'key'));
$this->getJson('/minhas-oportunidades/ofertas/'.$record['id'])->assertForbidden();
}
public function test_private_description_is_not_truncated_and_does_not_replace_an_existing_summary(): void
{
[$owner, $record, $payload] = $this->prepare();
$description = str_repeat('Synthetic complete description. ', 400);
$this->postJson('/minhas-oportunidades/ofertas/'.$record['id'].'/guardar', [
'etag' => $record['etag'], 'description' => $description, 'reason' => $payload['reason'],
])->assertOk();
$this->assertSame(trim($description), app(InvestorContext::class)->reference('opportunity:'.$record['id'])['fields']['project_summary']);
DB::table('opportunities')->where('id', $record['id'])->update(['summary' => 'Deliberate existing summary']);
$this->assertSame('Deliberate existing summary', app(InvestorContext::class)->reference('opportunity:'.$record['id'])['fields']['project_summary']);
$this->assertSame(trim($description), Opportunity::findOrFail($record['id'])->description);
}
public function test_approved_offer_continues_in_same_dossier_location_analysis_saved_result_and_report_input(): void
{
Mail::fake();
config(['editorial_workflow.enabled' => true, 'investor-path.enabled' => true, 'suitecrm.enabled' => false, 'investmoz_ai.enabled' => false]);
$country = (string) Str::uuid();
$province = (string) Str::uuid();
foreach ([[$country, 'country', null], [$province, 'province', $country]] as [$id, $type, $parent]) {
DB::table('geo_locations')->insert(['id' => $id, 'code' => 'SYNTHETIC-'.$id, 'name' => 'Synthetic '.$type,
'location_type' => $type, 'parent_id' => $parent, 'data_classification' => 'public',
// Same isolated reference contract as OpportunitySearchFixture; never an operational import.
'source_system' => 'cartografia-workbook',
'external_id' => '964a187ad32ea553b9e112cd159caa90b900050c42b7329594a75bcd798a96ff:'.$id]);
}
[$owner, $record, $payload] = $this->prepare(['province_id' => $province]);
$contact = (string) Str::uuid();
DB::table('contacts')->insert(['id' => $contact, 'full_name' => 'Synthetic private contact', 'source_system' => 'portal-user-contact', 'external_id' => 'user:'.$owner->id]);
$url = '/minhas-oportunidades/ofertas/'.$record['id'];
$this->postJson($url.'/guardar', ['etag' => $record['etag'], 'private_offer' => [...$payload['private_offer'], 'contact_id' => $contact], 'reason' => $payload['reason']])->assertOk();
$this->postJson($url.'/submeter', ['etag' => app(OpportunityManagement::class)->etag(Opportunity::findOrFail($record['id'])), 'confirm' => true])->assertOk()->assertJsonPath('record.state', 'submitted');
$reviewer = User::factory()->withTwoFactor()->create();
app(PortalProfileAdministration::class)->insertGrant((string) Str::uuid(), User::factory()->create(), [
'user_id' => $reviewer->id, 'role' => 'validator', 'responsibilities' => ['validation_coordinator'],
'opportunity_types' => ['business_sale'], 'source' => 'synthetic-acceptance-audit',
]);
$this->actingAs($reviewer)->withSession(['portal.mfa_actor' => $reviewer->id, 'portal.mfa_at' => time(), 'portal.access_revision' => (int) $reviewer->fresh()->portal_access_revision]);
foreach (['start_review', 'approve'] as $action) {
$this->postJson($url.'/revisao', ['etag' => app(OpportunityManagement::class)->etag(Opportunity::findOrFail($record['id'])),
'action' => $action, 'reason' => 'Synthetic independent review for investment continuity.'])->assertOk();
}
$offer = Opportunity::findOrFail($record['id']);
$public = ['title' => 'Synthetic public acquisition', 'summary' => 'Approved synthetic public summary only.', 'category' => 'business_sale',
'province_id' => $province, 'district_id' => null, 'price_mode' => 'negotiable', 'amount' => null, 'currency' => null];
$hash = OfferPublicCatalogue::projectionHash($public);
$context = $offer->workflow_context;
$context['offer_publication'] = ['contract' => OfferPublicCatalogue::CONTRACT, 'qa_fixture' => true, 'revision' => 1, 'payload' => $public,
'approval' => ['state' => 'approved', 'hash' => $hash, 'actor_id' => $reviewer->id, 'at' => now()->subMinutes(2)->toIso8601String()],
'publication' => ['state' => 'published', 'hash' => $hash, 'actor_id' => User::factory()->create()->id, 'at' => now()->subMinute()->toIso8601String()]];
$offer->forceFill(['workflow_context' => $context])->save();
$this->getJson('/api/v1/offers')->assertOk()->assertJsonPath('results.total', 0);
$this->app->instance(OfferPublicCatalogue::class, new OfferPublicCatalogue(true));
$response = $this->getJson('/api/v1/offers/'.$offer->id)->assertOk()->assertJsonPath('data.summary', $public['summary']);
$this->assertStringNotContainsString($payload['description'], $response->getContent());
$this->assertStringNotContainsString('60000.00', $response->getContent());
$this->assertNull($offer->fresh()->published_at);
$this->actingAs($owner);
$case = $this->postJson('/investimentos', ['title' => $payload['title'], 'client_key' => (string) Str::uuid(), 'reuse_consent' => true])->assertCreated()->json('id');
$view = $this->getJson('/investimentos/'.$case.'/contexto')->assertOk()->json();
$body = ['version' => $view['case']['version'], 'selection' => ['opportunity' => 'opportunity:'.$offer->id], 'declarations' => ['currency' => 'MZN']];
$plan = $this->postJson('/investimentos/'.$case.'/contexto/previa', $body)->assertOk()->json();
$this->assertSame($payload['description'], $plan['fields']['project_summary']);
$this->postJson('/investimentos/'.$case.'/contexto/confirmar', [...$body, 'preview_hash' => $plan['preview_hash'], 'operation_key' => (string) Str::uuid(), 'confirm' => true])->assertOk();
$view = $this->getJson('/investimentos/'.$case.'/contexto')->assertOk()->json();
$prefill = $view['prefill']['simulator'];
$this->assertSame($province, $prefill['province_id']);
$this->assertSame($payload['description'], $prefill['project_summary']);
$this->assertStringNotContainsString('60000.00', json_encode($view, JSON_THROW_ON_ERROR));
$financial = ['version' => 1, 'data' => ['budgetPeriod' => 'Mensal',
'loan' => ['principal' => '100000', 'rate' => '0', 'months' => '24', 'rateType' => 'nominal', 'periodMonths' => '1', 'gracePeriods' => '0', 'upfrontFee' => '0', 'recurringFee' => '0'],
'breakEven' => ['fixed' => '3000', 'price' => '100', 'variable' => '50'], 'funding' => ['total' => '100000', 'secured' => '30000'],
'incomes' => [['label' => 'Synthetic scenario revenue', 'amount' => '10000']],
'expenses' => [['label' => 'Declared rent at synthetic province', 'amount' => '2000'], ['label' => 'Declared transport at synthetic province', 'amount' => '1000']]]];
$draft = $this->postJson('/api/v1/simulation-drafts', ['context' => $case, 'personal_snapshot' => [],
'economic_snapshot' => [...array_intersect_key($prefill, array_flip(['purpose', 'journey_type', 'project_title', 'project_summary', 'currency', 'province_id', 'context_applicability_snapshot'])),
'financial_tools_snapshot' => json_encode($financial, JSON_THROW_ON_ERROR)]],
['Idempotency-Key' => (string) Str::uuid()])->assertCreated()->json('data.id');
$saved = $this->getJson('/api/v1/simulation-drafts/'.$draft.'?context='.$case)->assertOk()->json('data.economic_snapshot');
$this->assertSame($payload['description'], $saved['project_summary']);
$path = $this->getJson('/investimentos/'.$case)->assertOk()->json();
$this->postJson('/investimentos/'.$case.'/resultados', ['version' => $path['case']['version'], 'draft_id' => $draft, 'draft_version' => 1,
'context_revision' => $path['investment_context']['revision'], 'context_reviewed' => true])->assertOk();
auth()->logout();
$this->actingAs(User::findOrFail($owner->id));
$path = $this->getJson('/investimentos/'.$case)->assertOk()->json();
$this->assertSame($draft, $path['results'][0]['draft_id']);
$this->assertSame($payload['description'], $path['investment_context']['fields']['project_summary']);
$this->assertSame(1, Opportunity::count());
$this->assertSame(1, DB::table('desk_cases')->count());
$this->assertStringNotContainsString('60000.00', json_encode($path, JSON_THROW_ON_ERROR));
$output = base_path('outputs/offers-investment-continuity-20261114');
if (! is_dir($output)) {
mkdir($output, 0777, true);
}
file_put_contents($output.'/integrated-report-input.json', json_encode(['path' => $path, 'saved' => $saved], JSON_PRETTY_PRINT | JSON_THROW_ON_ERROR));
$body = ['version' => $path['case']['version'], 'selection' => ['opportunity' => 'opportunity:'.$offer->id],
'declarations' => ['project_summary' => 'Deliberate investment-specific summary']];
$plan = $this->postJson('/investimentos/'.$case.'/contexto/previa', $body)->assertOk()->json();
$this->assertSame('Deliberate investment-specific summary', $plan['fields']['project_summary']);
$this->postJson('/investimentos/'.$case.'/contexto/confirmar', [...$body, 'preview_hash' => $plan['preview_hash'], 'operation_key' => (string) Str::uuid(), 'confirm' => true])->assertOk();
$view = $this->getJson('/investimentos/'.$case.'/contexto')->assertOk()->json();
$this->postJson('/investimentos/'.$case.'/contexto/previa', ['version' => $view['case']['version'],
'selection' => ['opportunity' => 'opportunity:'.$offer->id]])->assertOk()->assertJsonPath('fields.project_summary', 'Deliberate investment-specific summary');
$this->assertSame($payload['description'], $offer->fresh()->description);
$this->actingAs(User::factory()->create())->getJson('/investimentos/'.$case)->assertForbidden();
$this->getJson('/api/v1/simulation-drafts/'.$draft.'?context='.$case)->assertNotFound();
}
}
@@ -5,6 +5,7 @@ namespace Tests\Feature;
use App\Jobs\ScanDocumentForMalware;
use App\Models\Opportunity;
use App\Models\User;
use App\Services\InvestorContext;
use App\Services\OpportunityManagement;
use App\Services\PortalProfileAdministration;
use App\Services\PrivateOfferConfidentiality;
@@ -19,6 +20,7 @@ use Illuminate\Support\Facades\Queue;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Str;
use Illuminate\Testing\TestResponse;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Tests\Support\CleanScannerFixture;
use Tests\TestCase;
@@ -238,6 +240,14 @@ final class PrivateOfferConfidentialityTest extends TestCase
$data = $this->login($interested)->getJson($url.'/confidencial')->assertOk()->assertJsonPath('business.revenue', '789.01')->getContent();
$this->assertStringNotContainsString('PRIVATE-CONTACT-CANARY', $data);
$this->assertStringNotContainsString('PRIVATE-DESCRIPTION-CANARY', $data);
// NDA permission is a bounded read, not permission to copy the private
// Opportunity into another investment context or its downstream reports.
try {
app(InvestorContext::class)->reference('opportunity:'.$record->id);
$this->fail('An NDA grant must not grant private investment-context access.');
} catch (HttpException $error) {
$this->assertSame(404, $error->getStatusCode());
}
$this->login($this->actor())->getJson($url.'/confidencial')->assertForbidden();
$this->login($owner)->postJson($url.'/confidencialidade', $this->command($record, $nda, 'revoke', ['interested_user_id' => $interested->id]))->assertOk();
$this->login($interested)->getJson($url.'/confidencial')->assertForbidden();
@@ -0,0 +1,94 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { readFileSync, writeFileSync } from 'node:fs';
import JSZip from 'jszip';
import {
calculateBudget,
calculateBreakEven,
restoreFinancialToolsSnapshot,
} from '../../resources/js/lib/financial-calculators.ts';
import { createInvestorDossierReport } from '../../resources/js/lib/investor-dossier-report.ts';
import {
createProjectDossierPrintHtml,
generateProjectDossierDocx,
} from '../../resources/js/lib/project-dossier-report.ts';
await test('persisted synthetic offer crosses the dossier boundary into location assumptions, calculation and private report', async () => {
// Produced by the guarded PHP integration test, never by an operational export.
const directory = new URL(
'../../outputs/offers-investment-continuity-20261114/',
import.meta.url,
);
const { path, saved } = JSON.parse(
readFileSync(
new URL('integrated-report-input.json', directory),
'utf8',
),
);
assert.equal(path.case.title, 'Synthetic acquisition acceptance');
assert.equal(
path.investment_context.fields.project_summary,
saved.project_summary,
);
assert.equal(path.investment_context.fields.province_id, saved.province_id);
const data = restoreFinancialToolsSnapshot(
path.results[0].financial_snapshot,
);
assert.ok(data);
assert.deepEqual(
data,
restoreFinancialToolsSnapshot(saved.financial_tools_snapshot),
);
const budget = calculateBudget(
data.incomes.map((row) => row.amount),
data.expenses.map((row) => row.amount),
);
const breakEven = calculateBreakEven(
data.breakEven.fixed,
data.breakEven.price,
data.breakEven.variable,
);
assert.equal(budget.operatingBalance, '7000.00');
assert.equal(breakEven.breakEvenUnits, '60');
// An explicit alternative location-cost assumption, not an inferred provincial tariff.
const alternative = calculateBudget(
data.incomes.map((row) => row.amount),
['5000', '3000'],
);
assert.equal(alternative.operatingBalance, '2000.00');
assert.deepEqual(
data.expenses.map((row) => row.amount),
['2000', '1000'],
);
const report = createInvestorDossierReport(path, '2026-11-14T12:00:00Z');
const html = await createProjectDossierPrintHtml(report, [], false);
assert.ok(html.includes(saved.project_summary));
assert.ok(html.includes('Synthetic province'));
assert.ok(!html.includes('60000.00'));
assert.ok(!html.includes('Synthetic private contact'));
const docx = await generateProjectDossierDocx(report, [], false);
const bytes = Buffer.from(await docx.arrayBuffer());
const zip = await JSZip.loadAsync(bytes);
const xml = await zip.file('word/document.xml').async('string');
assert.ok(xml.includes(saved.project_summary));
assert.ok(xml.includes('Synthetic province'));
assert.ok(!xml.includes('60000.00'));
writeFileSync(new URL('private-integrated-report.html', directory), html);
writeFileSync(new URL('private-integrated-report.docx', directory), bytes);
writeFileSync(
new URL('location-analysis.json', directory),
JSON.stringify(
{
scope: 'Synthetic investor-declared costs at the selected location; no automatic profitability or fiscal entitlement',
province_id: saved.province_id,
budget,
breakEven,
alternative,
source_offer: path.investment_context.selection.opportunity.key,
case_id: path.case.id,
},
null,
2,
),
);
});