Fix compressed draft saves provenance and Beira documentary continuity
tests / ci (push) Canceled after 0s

This commit is contained in:
2026-10-23 15:41:37 +02:00
parent c3f7c3ad10
commit 6b544548d3
16 changed files with 145 additions and 15 deletions
@@ -17,6 +17,41 @@ use Tests\TestCase;
final class InvestmentPortfolioContinuityTest extends TestCase
{
use DatabaseTransactions;
public function test_draft_version_guard_still_rejects_a_real_stale_version(): void
{
$draft = new \App\Models\SimulationFormDraft;
$draft->forceFill(['id'=>(string)Str::uuid(),'version_no'=>2]);
$service=app(\App\Services\SimulationFormDrafts::class);
$guard=new \ReflectionMethod($service,'requireMatch');
$tag=$service->etag($draft);
foreach (['W/'.$tag, str_replace('-v2','-v1',$tag)] as $invalid) {
$request=\Illuminate\Http\Request::create('/','PUT'); $request->headers->set('If-Match',$invalid);
try { $guard->invoke($service,$request,$draft); $this->fail('A mismatching version must be rejected'); }
catch (\Symfony\Component\HttpKernel\Exception\HttpException $error) { $this->assertSame(412,$error->getStatusCode()); }
}
$request=\Illuminate\Http\Request::create('/','PUT'); $request->headers->set('If-Match',$tag);
$this->assertNull($guard->invoke($service,$request,$draft));
}
public function test_beira_documentary_membership_opens_the_same_published_opportunities_without_inferring_by_province(): void
{
$portfolio = InvestmentPortfolioController::visible()->where('content->code', 'COR-02')->firstOrFail();
$service = app(CorridorAgribusinessOpportunities::class);
$ids = $service->portfolioOpportunityIds($portfolio);
$this->assertCount(7, $ids);
$this->get('/carteira/'.$portfolio->id)->assertOk()->assertInertia(fn(Assert $page) => $page->has('opportunities', 7));
$catalogueIds=app(\App\Services\InvestmentCatalogue::class)->query(['corridor_id'=>$portfolio->corridor_id])->pluck('opportunities.id')->all();
$this->assertSame([], array_values(array_diff($ids,$catalogueIds)));
$opportunity=Opportunity::findOrFail($ids[0]);
$this->get('/oportunidades/'.$opportunity->slug.'?from_dossier='.$portfolio->id)->assertOk();
$origins=app(InvestmentOpportunityChoices::class)->portfolioOrigins([$portfolio->id],$opportunity->id);
$this->assertSame($portfolio->id,$origins[0]['id']);
$this->assertSame('corridor',$origins[0]['kind']);
$other=Opportunity::published()->whereNotIn('id',$ids)->firstOrFail();
$this->get('/oportunidades/'.$other->slug.'?from_dossier='.$portfolio->id)->assertNotFound();
$this->assertSame([], $service->portfolioOpportunityIds(InvestmentPortfolioController::visible()->whereNotNull('project_id')->firstOrFail()));
}
private User $actor;
protected function setUp(): void
{
@@ -0,0 +1,22 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { inheritCompatibleFields } from '../../resources/js/lib/context-inheritance.ts';
import { buildProjectDossierRows, exportProjectDossierCsv } from '../../resources/js/lib/project-dossier.ts';
import { createProjectDossierReport, createProjectDossierPrintHtml } from '../../resources/js/lib/project-dossier-report.ts';
test('reports distinguish opportunity inheritance, dossier declarations and later edits without rewriting the snapshot', async()=>{
const source={project_title:'Título do promotor',project_summary:'Resumo da oportunidade',sector_id:'1',sector_id_label:'Agronegócio',context_applicability_snapshot:JSON.stringify({version:1,field_provenance:{project_summary:{kind:'opportunity',title:'Florestas — Corredor da Beira',version:2},sector_id:{kind:'opportunity',title:'Florestas — Corredor da Beira',version:2},project_title:{kind:'process_declaration',context_revision:1}}})};
const inherited=inheritCompatibleFields('dossier:A:simulator',{},source,null);
const draft={...inherited.patch,context_reuse:inherited.metadata};
let rows=buildProjectDossierRows(draft);
assert.match(rows.find(r=>r[1]==='Resumo')[3],/Herdado de oportunidade «Florestas/);
assert.match(rows.find(r=>r[1]==='Título')[3],/dados introduzidos pelo utilizador no dossier/);
const edited={...draft,project_summary:'Resumo alterado no simulador'}; const before=JSON.stringify(edited);
rows=buildProjectDossierRows(edited);
assert.match(rows.find(r=>r[1]==='Resumo')[3],/Alterado posteriormente pelo utilizador; origem anterior: oportunidade/);
assert.match(exportProjectDossierCsv(edited),/origem anterior: oportunidade/);
const report=createProjectDossierReport(edited,{selectedSections:new Set(['summary','project'])});
assert.match(await createProjectDossierPrintHtml(report,[],false),/Resumo alterado no simulador/);
assert.equal(JSON.stringify(edited),before);
assert.equal(buildProjectDossierRows({project_summary:'Legado'}).find(r=>r[1]==='Resumo')[3],'Declarado pelo utilizador');
});
@@ -0,0 +1,12 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { simulationDraftEtag } from '../../resources/js/lib/simulation-draft-etag.ts';
test('compressed draft reads use the exact version token while genuinely stale versions stay different', () => {
const tag='"sfd-6c07a968-7ff9-42fa-b252-072bb1acf221-v2"';
assert.equal(simulationDraftEtag(`W/${tag}`),tag);
assert.equal(simulationDraftEtag(tag),tag);
assert.notEqual(simulationDraftEtag(`W/${tag}`),tag.replace('-v2','-v3'));
assert.equal(simulationDraftEtag('W/"another-resource"'),'W/"another-resource"');
assert.equal(simulationDraftEtag(null),null);
});