fix(clusters): normalize persisted portable analysis version
This commit is contained in:
@@ -57,6 +57,7 @@ final class ClusterCompetitiveness
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
$clean = Validator::make($draft, $rules)->validate();
|
$clean = Validator::make($draft, $rules)->validate();
|
||||||
|
$clean['version'] = 1;
|
||||||
$clean['sector'] = trim($clean['sector'] ?? '');
|
$clean['sector'] = trim($clean['sector'] ?? '');
|
||||||
$clean['region'] = trim($clean['region'] ?? '');
|
$clean['region'] = trim($clean['region'] ?? '');
|
||||||
foreach (self::FORCES as $force) {
|
foreach (self::FORCES as $force) {
|
||||||
|
|||||||
@@ -121,6 +121,19 @@ class ClusterCompetitivenessTest extends TestCase
|
|||||||
$this->getJson($this->url($cluster))->assertJsonPath('version', 1)->assertJsonPath('draft.forces.buyers.source', '');
|
$this->getJson($this->url($cluster))->assertJsonPath('version', 1)->assertJsonPath('draft.forces.buyers.source', '');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function test_saved_data_keeps_the_portable_file_contract_and_rejects_missing_forces(): void
|
||||||
|
{
|
||||||
|
$this->manager();
|
||||||
|
$cluster = $this->cluster();
|
||||||
|
$draft = $this->draft($cluster);
|
||||||
|
$draft['version'] = '1';
|
||||||
|
$this->postJson($this->url($cluster).'/saved', ['expected_version' => 0, 'draft' => $draft])
|
||||||
|
->assertOk()->assertJsonPath('draft.version', 1);
|
||||||
|
unset($draft['forces']['suppliers']);
|
||||||
|
$this->postJson($this->url($cluster).'/saved', ['expected_version' => 1, 'draft' => $draft])->assertUnprocessable();
|
||||||
|
$this->getJson($this->url($cluster))->assertJsonPath('version', 1);
|
||||||
|
}
|
||||||
|
|
||||||
public function test_anonymous_and_unauthorised_users_cannot_read_history_or_mutate(): void
|
public function test_anonymous_and_unauthorised_users_cannot_read_history_or_mutate(): void
|
||||||
{
|
{
|
||||||
$cluster = $this->cluster();
|
$cluster = $this->cluster();
|
||||||
|
|||||||
Reference in New Issue
Block a user