feat(editorial): separate cluster analysis approval and publication in QA
This commit is contained in:
@@ -3,7 +3,9 @@
|
||||
namespace App\Services;
|
||||
|
||||
use App\Models\EconomicCluster;
|
||||
use App\Models\User;
|
||||
use Illuminate\Database\Query\Builder;
|
||||
use Illuminate\Support\Arr;
|
||||
use Illuminate\Support\Facades\Crypt;
|
||||
use Illuminate\Support\Facades\DB;
|
||||
use Illuminate\Support\Facades\Validator;
|
||||
@@ -46,6 +48,12 @@ final class ClusterCompetitiveness
|
||||
public function management(string $cluster): array
|
||||
{
|
||||
$state = $this->current($cluster);
|
||||
$state['editorial_enabled'] = $this->editorialEnabled();
|
||||
if (isset($state['workflow'])) {
|
||||
$record = EconomicCluster::findOrFail($cluster);
|
||||
$state['workflow']['fresh'] = hash_equals($state['workflow']['hash'], $this->editionHash($record, $state['draft']));
|
||||
$state['workflow']['independent_required'] = $this->independentRequired($state['workflow']);
|
||||
}
|
||||
$state['history'] = $this->events($cluster)->orderByRaw("(after_data->>'version')::integer DESC")->limit(50)->get()
|
||||
->map(fn ($event) => ['version' => json_decode($event->after_data, true)['version'],
|
||||
'action' => $event->action, 'at' => $event->occurred_at, 'actor' => $event->actor_user_id])->all();
|
||||
@@ -106,12 +114,17 @@ final class ClusterCompetitiveness
|
||||
*/
|
||||
public function change(EconomicCluster $cluster, int $actor, int $expected, string $action, array $input = []): array
|
||||
{
|
||||
abort_if(! in_array($action, ['saved', 'restored', 'approved', 'withdrawn'], true) && ! $this->editorialEnabled(), 503, 'Circuito editorial dos clusters ainda não activado.');
|
||||
|
||||
return DB::transaction(function () use ($cluster, $actor, $expected, $action, $input) {
|
||||
EconomicCluster::whereKey($cluster->id)->lockForUpdate()->firstOrFail();
|
||||
$cluster = EconomicCluster::whereKey($cluster->id)->lockForUpdate()->firstOrFail();
|
||||
$before = $this->current($cluster->id);
|
||||
abort_if($before['version'] !== $expected, 409, 'A análise foi alterada. Conserve os campos actuais e compare a versão do servidor antes de voltar a guardar.');
|
||||
$state = $before;
|
||||
if ($action === 'saved') {
|
||||
if ($this->editorialEnabled() || isset($before['workflow'])) {
|
||||
abort_unless($this->editorialEnabled(), 503, 'Reactive o circuito editorial para continuar esta análise; o histórico e a publicação foram conservados.');
|
||||
$state = $this->editorialChange($cluster, $actor, $action, $input, $before);
|
||||
} elseif ($action === 'saved') {
|
||||
$state['draft'] = $this->validateDraft($input['draft'], $cluster->id);
|
||||
} elseif ($action === 'restored') {
|
||||
$event = $this->events($cluster->id)->where('after_data->version', $input['revision'])->first();
|
||||
@@ -144,9 +157,101 @@ final class ClusterCompetitiveness
|
||||
*/
|
||||
public function publicData(string $cluster): ?array
|
||||
{
|
||||
$approved = $this->current($cluster)['approved'];
|
||||
$state = $this->current($cluster);
|
||||
$approved = isset($state['workflow']) ? $state['published'] : $state['approved'];
|
||||
|
||||
// Explicit projection: never return editor identity, approval evidence, history or the unapproved draft.
|
||||
return $approved ? ['draft' => $approved['draft'], 'version' => $approved['version'], 'at' => $approved['at']] : null;
|
||||
}
|
||||
|
||||
public function editorialEnabled(): bool
|
||||
{
|
||||
return (bool) config('editorial_workflow.cluster_competitiveness');
|
||||
}
|
||||
|
||||
/** @param array<array-key,mixed>|null $draft */
|
||||
private function editionHash(EconomicCluster $cluster, ?array $draft): string
|
||||
{
|
||||
$context = Arr::only($cluster->getAttributes(), ['id', 'code', 'name', 'sector', 'status', 'primary_territory_id', 'territory_version']);
|
||||
|
||||
return hash('sha256', json_encode(Arr::sortRecursive(['context' => $context, 'draft' => $draft]), JSON_THROW_ON_ERROR));
|
||||
}
|
||||
|
||||
/** @param array<array-key,mixed> $input
|
||||
* @param array<array-key,mixed> $state
|
||||
* @return array<array-key,mixed>
|
||||
*/
|
||||
private function editorialChange(EconomicCluster $cluster, int $actorId, string $action, array $input, array $state): array
|
||||
{
|
||||
$actor = User::whereKey($actorId)->firstOrFail();
|
||||
abort_unless($actor->can('manage-portal') && ! app(PortalProfileAccess::class)->has($actor, 'auditor'), 403);
|
||||
abort_unless(app(PortalProfileAccess::class)->mfa($actor), 403, 'Confirme o MFA na sessão existente.');
|
||||
if (! isset($state['workflow'])) {
|
||||
abort_unless(in_array($action, ['saved', 'restored', 'withdrawn'], true), 409, 'Guarde uma edição privada antes de iniciar o novo circuito.');
|
||||
// An accepted legacy publication remains public; no retrospective approval is invented.
|
||||
$state['published'] = $state['approved'];
|
||||
$state['approved'] = null;
|
||||
$state['workflow'] = ['state' => 'draft', 'edition' => $state['version'], 'contributors' => [], 'approval' => null,
|
||||
'hash' => $this->editionHash($cluster, $state['draft']), 'independent_required' => false];
|
||||
}
|
||||
$workflow = $state['workflow'];
|
||||
if (in_array($action, ['saved', 'restored'], true)) {
|
||||
if ($action === 'saved') {
|
||||
$state['draft'] = $this->validateDraft($input['draft'], $cluster->id);
|
||||
$restoredContributors = [];
|
||||
} else {
|
||||
$event = $this->events($cluster->id)->where('after_data->version', $input['revision'])->first();
|
||||
abort_unless($event !== null, 404);
|
||||
$restored = $this->decode($event);
|
||||
$state['draft'] = $restored['draft'];
|
||||
$restoredContributors = $restored['workflow']['contributors'] ?? [$event->actor_user_id];
|
||||
}
|
||||
$state['approved'] = null;
|
||||
$state['workflow'] = ['state' => 'draft', 'edition' => $state['version'] + 1,
|
||||
'contributors' => array_values(array_unique([...($workflow['state'] === 'published' ? [] : $workflow['contributors']), ...$restoredContributors, $actorId])),
|
||||
'hash' => $this->editionHash($cluster, $state['draft']), 'approval' => null,
|
||||
'independent_required' => $this->independentRequired($workflow)];
|
||||
|
||||
return $state;
|
||||
}
|
||||
validator($input, ['reason' => 'required|string|min:10|max:3000'])->validate();
|
||||
$allowed = ['submitted' => ['draft', 'returned'], 'review_started' => ['submitted'], 'returned' => ['in_review'], 'rejected' => ['in_review'],
|
||||
'approved' => ['in_review'], 'published' => ['approved'], 'archived' => ['draft', 'submitted', 'in_review', 'returned', 'rejected', 'approved', 'published'], 'withdrawn' => ['draft', 'submitted', 'in_review', 'returned', 'rejected', 'approved', 'published', 'archived']];
|
||||
abort_unless(isset($allowed[$action]) && in_array($workflow['state'], $allowed[$action], true), 409, 'Transição incompatível com o estado da edição.');
|
||||
if (in_array($action, ['submitted', 'approved', 'published'], true)) {
|
||||
abort_unless(hash_equals($workflow['hash'], $this->editionHash($cluster, $state['draft'])), 409, 'O contexto do cluster mudou. Guarde nova edição e volte a conferir.');
|
||||
}
|
||||
if ($action === 'submitted' || $action === 'approved') {
|
||||
$this->assertComplete($state['draft']);
|
||||
}
|
||||
if ($action === 'approved') {
|
||||
abort_if($this->independentRequired($workflow) && in_array($actorId, $workflow['contributors'], true), 403, 'Aprovação independente necessária para esta edição.');
|
||||
$workflow['approval'] = ['actor' => $actorId, 'edition' => $workflow['edition'], 'hash' => $workflow['hash'], 'at' => now()->toISOString(), 'reason' => $input['reason']];
|
||||
$state['approved'] = ['draft' => $state['draft'], 'at' => now()->toISOString(), 'actor' => $actorId, 'version' => $state['version'] + 1, 'evidence' => $input['reason']];
|
||||
}
|
||||
if ($action === 'published') {
|
||||
$decision = $workflow['approval'];
|
||||
abort_unless($decision && $decision['edition'] === $workflow['edition'] && hash_equals($decision['hash'], $workflow['hash']), 422, 'Aprovação desta edição necessária.');
|
||||
$reviewer = User::whereKey($decision['actor'])->first();
|
||||
abort_unless($reviewer && $reviewer->can('manage-portal') && ! app(PortalProfileAccess::class)->has($reviewer, 'auditor'), 403, 'Autoridade da aprovação revogada.');
|
||||
abort_if($this->independentRequired($workflow) && in_array($reviewer->id, $workflow['contributors'], true), 403, 'Aprovação independente necessária.');
|
||||
$state['published'] = [...$state['approved'], 'at' => now()->toISOString(), 'version' => $state['version'] + 1];
|
||||
}
|
||||
if ($action === 'withdrawn' || ($action === 'archived' && $workflow['state'] === 'published')) {
|
||||
$state['published'] = null;
|
||||
}
|
||||
$workflow['state'] = match ($action) {
|
||||
'submitted' => 'submitted', 'review_started' => 'in_review', 'returned' => 'returned', 'rejected' => 'rejected',
|
||||
'approved' => 'approved', 'published' => 'published', 'archived' => 'archived', 'withdrawn' => $workflow['state'] === 'published' ? 'archived' : $workflow['state'],
|
||||
};
|
||||
$state['workflow'] = $workflow;
|
||||
|
||||
return $state;
|
||||
}
|
||||
|
||||
/** @param array<array-key,mixed> $workflow */
|
||||
private function independentRequired(array $workflow): bool
|
||||
{
|
||||
return ($workflow['independent_required'] ?? false) || in_array('cluster_competitiveness', config('editorial_workflow.independent_approval.kinds', []), true);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user