fix: explain IVA query conditions and distinguish integration failures

This commit is contained in:
2026-10-21 13:35:22 +02:00
parent bd5166bd11
commit 0d7b70459d
15 changed files with 327 additions and 24 deletions
@@ -76,6 +76,33 @@ class SimulationPublishedFiscalTest extends TestCase
return Simulation::with('reports')->findOrFail($id);
}
public function test_iva_query_diagnostics_explain_the_reported_contract_gap_without_calculating_or_changing_answers(): void
{
$count = Simulation::count();
$input = ['component' => 'IVA', 'period_start' => '2026-01-01', 'period_end' => '2026-12-31',
'context' => ['fiscal_operation' => 'domestic', 'currency' => 'USD']];
$this->actingAs($this->consumer)->postJson('/api/v1/tax-parameters/resolve', $input)->assertOk()
->assertJsonPath('assumptions.currency', 'USD')
->assertJsonPath('parameters.0.status', 'indeterminate_context')
->assertJsonPath('diagnostics.0.label', 'IVA — taxa geral')
->assertJsonPath('diagnostics.0.rule_version', 1)
->assertJsonPath('diagnostics.0.issues.1.category', 'system_configuration')
->assertJsonPath('diagnostics.0.issues.1.received', 'domestic')
->assertJsonPath('diagnostics.0.issues.0.category', 'out_of_scope')
->assertJsonPath('diagnostics.0.issues.0.received', 'USD')
->assertJsonPath('diagnostics.0.issues.0.expected', 'MZN');
unset($input['context']['currency']);
$this->postJson('/api/v1/tax-parameters/resolve', $input)->assertOk()
->assertJsonPath('diagnostics.0.issues.0.category', 'missing_field');
$input['context']['currency'] = 'MZN';
$input['period_start'] = '2022-01-01';
$input['period_end'] = '2022-12-31';
$this->postJson('/api/v1/tax-parameters/resolve', $input)->assertOk()
->assertJsonPath('parameters', [])
->assertJsonPath('diagnostics.0.issues.0.category', 'period_unavailable');
self::assertSame($count, Simulation::count());
}
public function test_normal_simulator_admits_published_rule_and_reuses_history_and_reports(): void
{
$key = (string) Str::uuid();
@@ -0,0 +1,71 @@
<?php
namespace Tests\Unit;
use App\Services\SimulationIvaDiagnostics;
use App\Services\SimulationTaxParameterResolver;
use PHPUnit\Framework\TestCase;
final class SimulationIvaDiagnosticsTest extends TestCase
{
private function version(): array
{
return ['id' => 'synthetic-qa', 'rule_code' => 'IVA-GERAL-BASE-LIQUIDA', 'rule_version' => 1,
'component' => 'IVA', 'status' => 'published', 'scope_key' => 'mz.internal-general-net.mzn',
'valid_from' => '2023-01-01', 'valid_until' => null, 'source_version_no' => 1,
'source_sha256' => str_repeat('a', 64), 'rule_definition' => ['language' => 'investmoz.tax.v1'],
'parameters' => ['IVA_GENERAL_RATE' => ['value' => '16', 'unit' => 'percent', 'conditions' => ['operation' => 'internal_general_net', 'currency' => 'MZN']]],
'source' => ['validation_status' => 'validated', 'version_no' => 1, 'valid_from' => '2023-01-01', 'valid_until' => null,
'title' => 'Synthetic source', 'diploma' => 'QA only', 'article' => 'Fixture', 'url' => 'https://example.invalid/official']];
}
public function test_reported_annual_query_contract_reproduces_the_generic_failure_and_identifies_both_missing_links(): void
{
$version = $this->version();
$context = ['fiscal_operation' => 'domestic'];
$original = $context;
$before = (new SimulationTaxParameterResolver)->resolveAvailableParameters([$version], 'IVA', '2026-01-01', '2026-12-31', $context);
self::assertSame('indeterminate_context', $before[0]['status']);
$details = (new SimulationIvaDiagnostics)->explain([$version], '2026-01-01', '2026-12-31', $context);
self::assertSame(['system_configuration', 'missing_field'], array_column($details[0]['issues'], 'category'));
self::assertSame('domestic', $details[0]['issues'][0]['received']);
self::assertSame('MZN', $details[0]['issues'][1]['expected']);
self::assertSame($original, $context);
self::assertArrayNotHasKey('rule_definition', $details[0]);
self::assertArrayNotHasKey('rule_code', $details[0]);
}
public function test_all_failed_conditions_are_separate_and_currency_is_not_assumed(): void
{
foreach (['' => 'missing_field', 'usd' => 'invalid_value', 'USD' => 'out_of_scope'] as $value => $category) {
$details = (new SimulationIvaDiagnostics)->explain([$this->version()], '2026-01-01', '2026-12-31', ['operation' => 'import', 'currency' => $value]);
self::assertCount(2, $details[0]['issues']);
self::assertSame('out_of_scope', $details[0]['issues'][0]['category']);
self::assertSame($category, $details[0]['issues'][1]['category']);
}
}
public function test_period_and_broken_source_are_not_reported_as_incorrect_answers(): void
{
$version = $this->version();
$version['source_version_no'] = 2;
$details = (new SimulationIvaDiagnostics)->explain([$version], '2022-01-01', '2022-12-31', ['operation' => 'internal_general_net', 'currency' => 'MZN']);
self::assertSame(['period_unavailable', 'system_configuration'], array_column($details[0]['issues'], 'category'));
self::assertSame('2022-01-01 a 2022-12-31', $details[0]['issues'][0]['received']);
self::assertSame(1, $details[0]['rule_version']);
self::assertSame('Synthetic source', $details[0]['source']['title']);
}
public function test_matching_context_has_no_diagnostic_and_does_not_evaluate_an_expression(): void
{
self::assertSame([], (new SimulationIvaDiagnostics)->explain([$this->version()], '2026-01-01', '2026-12-31', ['operation' => 'internal_general_net', 'currency' => 'MZN']));
}
public function test_an_explicitly_excluded_generic_operation_is_reported_without_inferring_a_domestic_scope(): void
{
$details = (new SimulationIvaDiagnostics)->explain([$this->version()], '2026-01-01', '2026-12-31', ['fiscal_operation' => 'import', 'currency' => 'MZN']);
self::assertCount(1, $details[0]['issues']);
self::assertSame('out_of_scope', $details[0]['issues'][0]['category']);
self::assertSame('import', $details[0]['issues'][0]['received']);
}
}